Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --install-in-builtin-dir flag to lib install command #2077

Merged
merged 3 commits into from
Feb 20, 2023

Conversation

cmaglie
Copy link
Member

@cmaglie cmaglie commented Feb 16, 2023

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Adds --install-in-builtin-dir flag to lib install command.

What is the current behavior?

What is the new behavior?

When the --install-in-builtin-dir flag is set, the libraries are installed in the directory specified by the directories.builtin.libraries configuration setting:

directories:
  builtin.libraries: /home/user/.....

The libraries installed inside the builtin directory are not automatically upgraded via lib upgrade. They can be upgraded anyway, by forcing an install of an already installed library.

Does this PR introduce a breaking change, and is titled accordingly?

No

Other information

@cmaglie cmaglie requested a review from umbynos February 16, 2023 13:00
@cmaglie cmaglie self-assigned this Feb 16, 2023
@cmaglie cmaglie added type: enhancement Proposed improvement topic: code Related to content of the project itself labels Feb 16, 2023
@cmaglie cmaglie added this to the Arduino CLI 0.31.0 milestone Feb 16, 2023
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Base: 36.64% // Head: 36.60% // Decreases project coverage by -0.04% ⚠️

Coverage data is based on head (4410d08) compared to base (53a6f25).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2077      +/-   ##
==========================================
- Coverage   36.64%   36.60%   -0.04%     
==========================================
  Files         229      229              
  Lines       19471    19491      +20     
==========================================
  Hits         7135     7135              
- Misses      11498    11518      +20     
  Partials      838      838              
Flag Coverage Δ
unit 36.60% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
commands/lib/install.go 0.00% <0.00%> (ø)
internal/cli/lib/install.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmaglie cmaglie merged commit d6196c1 into arduino:master Feb 20, 2023
@cmaglie cmaglie deleted the improve_query_params branch February 20, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: code Related to content of the project itself type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants