[breaking] Remove ip flag from daemon command
#2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatteoPologruto
added
topic: security
Codecov ReportBase: 36.55% // Head: 36.56% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2045 +/- ##
==========================================
+ Coverage 36.55% 36.56% +0.01%
==========================================
Files 229 229
Lines 19383 19383
==========================================
+ Hits 7085 7088 +3
+ Misses 11462 11460 -2
+ Partials 836 835 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
umbynos
requested changes
Jan 24, 2023
There was a problem hiding this comment.
Since this is a breaking change UPGRADING.md needs to be updates accordingly
MatteoPologruto
force-pushed
the
remove-daemon-ip-flag
branch
from
bf9b98a
to
741e065
Compare
MatteoPologruto
changed the title
ip flag from daemon commandip flag from daemon command
MatteoPologruto
force-pushed
the
remove-daemon-ip-flag
branch
from
741e065
to
c829944
Compare
umbynos
approved these changes
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Code security improvement
What is the current behavior?
It is currently possible to use
--ipto set a custom ip for listening to gRPC request.What is the new behavior?
The
--ipflag is removed and the default value is set to127.0.0.1.Does this PR introduce a breaking change, and is titled accordingly?
Yes