refactoring: Fixing legacy pathnames

[cmaglie]

Please check if the PR fulfills these requirements

See how to contribute

• The PR has no duplicates (please search among the Pull Requests
  before creating one)
• The PR follows
  our contributing guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)
• UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Some changes and cleanup on the legacy wrt build paths.
There is a lot of redundancy in the legacy builder, this PR aims to remove all code duplication.

What is the current behavior?

No changes in behavior, this PR should be equivalent code change.

What is the new behavior?

Does this PR introduce a breaking change, and is titled accordingly?

No breaking changes

Other information

[codecov]

Codecov Report

Base: 36.56% // Head: 36.47% // Decreases project coverage by -0.10% ⚠️

Coverage data is based on head (9fd565d) compared to base (a63aff4).
Patch coverage: 61.11% of modified lines in pull request are covered.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2038      +/-   ##
==========================================
- Coverage   36.56%   36.47%   -0.10%     
==========================================
  Files         229      228       -1     
  Lines       19383    19306      -77     
==========================================
- Hits         7088     7042      -46     
+ Misses      11460    11438      -22     
+ Partials      835      826       -9     

Flag	Coverage Δ
unit	36.47% <61.11%> (-0.10%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
commands/compile/compile.go	0.00% <0.00%> (ø)
...egacy/builder/add_additional_entries_to_context.go	62.50% <ø> (+1.97%)	⬆️
legacy/builder/builder.go	84.84% <ø> (+3.68%)	⬆️
legacy/builder/container_setup.go	85.71% <ø> (+2.07%)	⬆️
commands/debug/debug_info.go	45.04% <33.33%> (-1.75%)	⬇️
legacy/builder/types/context.go	73.52% <71.42%> (-1.17%)	⬇️
arduino/sketch/sketch.go	63.79% <100.00%> (-1.75%)	⬇️
commands/upload/upload.go	54.73% <100.00%> (ø)
...acy/builder/fail_if_buildpath_equals_sketchpath.go	100.00% <100.00%> (+50.00%)	⬆️
legacy/builder/setup_build_properties.go	85.86% <100.00%> (+2.36%)	⬆️
... and 9 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.