Skip to content

fix: scan libraries on install #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 19, 2023
Merged

fix: scan libraries on install #2037

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5c12c8f
fix: scan libraries before install
Jan 18, 2023
98ee870
test: rescan libraries to clear them beforehand
Jan 18, 2023
6e5a811
test: rescan libraries before install
Jan 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: scan libraries before install
  • Loading branch information
Luca Bianconi committed Jan 18, 2023
commit 5c12c8f1502c9843e983313428ad64d65cf4386a
1 change: 1 addition & 0 deletions arduino/libraries/librariesmanager/install.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ func (lm *LibrariesManager) InstallPrerequisiteCheck(name string, version *semve
return nil, err
}

lm.RescanLibraries()
libs := lm.FindByReference(&librariesindex.Reference{Name: name}, installLocation)

if len(libs) > 1 {
Expand Down
7 changes: 7 additions & 0 deletions arduino/libraries/librariesmanager/librariesmanager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,8 +130,15 @@ func (lm *LibrariesManager) AddPlatformReleaseLibrariesDir(plaftormRelease *core
})
}

func (lm *LibrariesManager) ClearLibraries() {
for k := range lm.Libraries {
delete(lm.Libraries, k)
}
}

// RescanLibraries reload all installed libraries in the system.
func (lm *LibrariesManager) RescanLibraries() []*status.Status {
lm.ClearLibraries()
statuses := []*status.Status{}
for _, dir := range lm.LibrariesDir {
if errs := lm.LoadLibrariesFromDir(dir); len(errs) > 0 {
Expand Down