Set runtime.hardware.path property during upload
#1978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmaglie
added
priority: medium
cmaglie
force-pushed
the
fix_runtime_props
branch
from
ec2b090
to
15097bc
Compare
umbynos
approved these changes
Nov 16, 2022
cmaglie
force-pushed
the
fix_runtime_props
branch
from
3041e66
to
15097bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
See how to contribute
before creating one)
our contributing guidelines
UPGRADING.mdhas been updated with a migration guide (for breaking changes)What kind of change does this PR introduce?
Set
runtime.hardware.pathproperty during upload.What is the current behavior?
runtime.hardware.pathproperty is empty during upload (it is only set for compile).What is the new behavior?
runtime.hardware.pathproperty is set during upload too.Does this PR introduce a breaking change, and is titled accordingly?
No
Other information
Fix #1971