cli: board search use feedback result structs

Author: alessio-perugini

internal/cli/board/search.go

@@ -24,6 +24,7 @@ import (
 
 	"github.com/arduino/arduino-cli/commands/board"
 	"github.com/arduino/arduino-cli/internal/cli/feedback"
+	fResult "github.com/arduino/arduino-cli/internal/cli/feedback/result"
 	"github.com/arduino/arduino-cli/internal/cli/instance"
 	rpc "github.com/arduino/arduino-cli/rpc/cc/arduino/cli/commands/v1"
 	"github.com/arduino/arduino-cli/table"
@@ -60,32 +61,40 @@ func runSearchCommand(cmd *cobra.Command, args []string) {
 		feedback.Fatal(tr("Error searching boards: %v", err), feedback.ErrGeneric)
 	}
 
-	feedback.PrintResult(searchResults{res.Boards})
+	feedback.PrintResult(searchResults{fResult.NewBoardListItems(res.Boards)})
 }
 
 // output from this command requires special formatting so we create a dedicated
 // feedback.Result implementation
 type searchResults struct {
-	boards []*rpc.BoardListItem
+	boards []*fResult.BoardListItem
 }
 
 func (r searchResults) Data() interface{} {
 	return r.boards
 }
 
 func (r searchResults) String() string {
+	t := table.New()
+	t.SetHeader(tr("Board Name"), tr("FQBN"), tr("Platform ID"), "")
+
+	if len(r.boards) == 0 {
+		return t.Render()
+	}
+
 	sort.Slice(r.boards, func(i, j int) bool {
-		return r.boards[i].GetName() < r.boards[j].GetName()
+		return r.boards[i].Name < r.boards[j].Name
 	})
 
-	t := table.New()
-	t.SetHeader(tr("Board Name"), tr("FQBN"), tr("Platform ID"), "")
 	for _, item := range r.boards {
+		if item == nil {
+			continue
+		}
 		hidden := ""
 		if item.IsHidden {
 			hidden = tr("(hidden)")
 		}
-		t.AddRow(item.GetName(), item.GetFqbn(), item.Platform.Metadata.Id, hidden)
+		t.AddRow(item.Name, item.Fqbn, item.Platform.Metadata.Id, hidden)
 	}
 	return t.Render()
 }

internal/cli/feedback/result/rpc.go

@@ -621,6 +621,17 @@ type BoardListItem struct {
 	Platform *Platform `json:"platform,omitempty"`
 }
 
+func NewBoardListItems(b []*rpc.BoardListItem) []*BoardListItem {
+	if b == nil {
+		return nil
+	}
+	res := make([]*BoardListItem, len(b))
+	for i, v := range b {
+		res[i] = NewBoardListItem(v)
+	}
+	return res
+}
+
 func NewBoardListItem(b *rpc.BoardListItem) *BoardListItem {
 	if b == nil {
 		return nil