Include pre-uninstall script run into the unit test

Author: MatteoPologruto

arduino/cores/packagemanager/package_manager_test.go

@@ -921,7 +921,7 @@ func TestVariantAndCoreSelection(t *testing.T) {
 	})
 }
 
-func TestRunPostInstall(t *testing.T) {
+func TestRunScript(t *testing.T) {
 	pmb := NewBuilder(nil, nil, nil, nil, "test")
 	pm := pmb.Build()
 	pme, release := pm.NewExplorer()
@@ -930,29 +930,49 @@ func TestRunPostInstall(t *testing.T) {
 	// prepare dummy post install script
 	dir := paths.New(t.TempDir())
 
-	var scriptPath *paths.Path
-	var err error
-	if runtime.GOOS == "windows" {
-		scriptPath = dir.Join("post_install.bat")
-
-		err = scriptPath.WriteFile([]byte(
-			`@echo off
-			echo sent in stdout
-			echo sent in stderr 1>&2`))
-	} else {
-		scriptPath = dir.Join("post_install.sh")
-		err = scriptPath.WriteFile([]byte(
-			`#!/bin/sh
-			echo "sent in stdout"
-			echo "sent in stderr" 1>&2`))
+	type Test struct {
+		testName   string
+		scriptName string
+	}
+
+	tests := []Test{
+		{
+			testName:   "PostInstallScript",
+			scriptName: "post_install",
+		},
+		{
+			testName:   "PreUninstallScript",
+			scriptName: "pre_uninstall",
+		},
 	}
-	require.NoError(t, err)
-	err = os.Chmod(scriptPath.String(), 0777)
-	require.NoError(t, err)
-	stdout, stderr, err := pme.RunPreOrPostScript(dir, "post_install")
-	require.NoError(t, err)
 
-	// `HasPrefix` because windows seem to add a trailing space at the end
-	require.Equal(t, "sent in stdout", strings.Trim(string(stdout), "\n\r "))
-	require.Equal(t, "sent in stderr", strings.Trim(string(stderr), "\n\r "))
+	for _, test := range tests {
+		t.Run(test.testName, func(t *testing.T) {
+			var scriptPath *paths.Path
+			var err error
+			if runtime.GOOS == "windows" {
+				scriptPath = dir.Join(test.scriptName + ".bat")
+
+				err = scriptPath.WriteFile([]byte(
+					`@echo off
+					echo sent in stdout
+					echo sent in stderr 1>&2`))
+			} else {
+				scriptPath = dir.Join(test.scriptName + ".sh")
+				err = scriptPath.WriteFile([]byte(
+					`#!/bin/sh
+					echo "sent in stdout"
+					echo "sent in stderr" 1>&2`))
+			}
+			require.NoError(t, err)
+			err = os.Chmod(scriptPath.String(), 0777)
+			require.NoError(t, err)
+			stdout, stderr, err := pme.RunPreOrPostScript(dir, test.scriptName)
+			require.NoError(t, err)
+
+			// `HasPrefix` because windows seem to add a trailing space at the end
+			require.Equal(t, "sent in stdout", strings.Trim(string(stdout), "\n\r "))
+			require.Equal(t, "sent in stderr", strings.Trim(string(stderr), "\n\r "))
+		})
+	}
 }