Skip to content

Commit 6a4a510

Browse files
committed
Fixed progress bar race conditions
1 parent 152055c commit 6a4a510

File tree

7 files changed

+34
-30
lines changed

7 files changed

+34
-30
lines changed

Gopkg.lock

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

common/formatter/text.go

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -57,13 +57,7 @@ func (tp *TextFormatter) DownloadProgressBar(resp *grab.Response, prefix string)
5757
case <-t.C:
5858
bar.Set(int(resp.BytesComplete()))
5959
case <-resp.Done:
60-
bar.ShowCounters = false
61-
bar.ShowPercent = false
62-
bar.ShowFinalTime = false
63-
bar.ShowBar = false
64-
bar.Prefix(prefix + " downloaded")
65-
bar.Set(int(resp.BytesComplete()))
66-
bar.Finish()
60+
bar.FinishPrintOver(prefix + " downloaded")
6761
return
6862
}
6963
}

vendor/gopkg.in/cheggaaa/pb.v1/.travis.yml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/gopkg.in/cheggaaa/pb.v1/README.md

Lines changed: 3 additions & 3 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/gopkg.in/cheggaaa/pb.v1/format.go

Lines changed: 8 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/gopkg.in/cheggaaa/pb.v1/pb.go

Lines changed: 16 additions & 15 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

vendor/gopkg.in/cheggaaa/pb.v1/pb_win.go

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)