Relax library matching rules when detecting libraries #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facchinm
approved these changes
Jan 31, 2017
Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
markImportedLibrary is lost after function returns so it's useless to update it just before returning. Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
Even when there is only one candidate library for a particular header we should always check if the library is already included. Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
It may have had its purposes in the past, but now it's basically useless since it's only used to cycle in `for... range` loops. Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
This allows to set the correct library priority, for example, if the library is named "My Library" but the include file is "my_library.h". Signed-off-by: Cristian Maglie <c.maglie@arduino.cc>
cmaglie
force-pushed
the
improve-lib-matching
branch
from
49fc46b to
aea468e
Compare
matthijskooijman
approved these changes
Feb 1, 2017
| if len(libraries) == 1 { | ||
| return libraries[0] | ||
| } | ||
|
|
||
| if markImportedLibraryContainsOneOfCandidates(markImportedLibrary, libraries) { | ||
| return nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Note that this should actually never occur at all, if the header is available, it is never returned as missing by the preprocessor (this was different when include scanning was still regex-based instead of preprocessor-based). Keeping this if in might be a good idea, though, but perhaps it should be marked as "just in case" with a comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to set the correct library priority, for example, if the library is named "My Library" but the include file is "my_library.h".
/cc @matteosuppo @facchinm