Remove programmer properties from openocd upload pattern #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform properties may be associated with a specific programmer selection in the programmers.txt configuration file. These properties can be used in the platform.txt patterns for the actions that use the programmer: - `program` - `erase` - `bootloader` However, those properties are not expanded in the `upload` pattern, since it does not use the programmer: https://arduino.github.io/arduino-cli/dev/platform-specification/#programmerstxt > These properties can only be used in the recipes of the actions that use the programmer (erase, bootloader, and program). While enhancing the ability to make programmer-specific configuration of the patterns, programmer-associated properties were introduced into `tools.openocd.upload.pattern`, which caused uploads to fail for the "Arduino Zero (Programming Port)" board: ``` Unexpected command line argument: {extra_params} ``` The upload pattern is hereby reverted to the previous working configuration, leaving the beneficial changes to the other patterns.
|
Memory usage change @ 719d9c6
Click for full report table
|
1 similar comment
|
Memory usage change @ 719d9c6
Click for full report table
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform properties may be associated with a specific programmer selection in the
programmers.txtconfiguration file. These properties can be used in theplatform.txtpatterns for the actions that use the programmer:programerasebootloaderHowever, those properties are not expanded in the
uploadpattern, since it does not use the programmer:https://arduino.github.io/arduino-cli/dev/platform-specification/#programmerstxt
While enhancing the ability to make programmer-specific configuration of the patterns (#636), programmer-associated properties were introduced into
tools.openocd.upload.pattern, which caused uploads to fail for the "Arduino Zero (Programming Port)" board:The
uploadpattern is hereby reverted to the previous working configuration, leaving the beneficial changes to the other patterns.Originally reported at https://forum.arduino.cc/t/unexpected-command-line-argument-extra-params/929834