Merge pull request #618 from bxparks/saferingbuffer

SafeRingBuffer.h: Prevent compiler warning about reaching end of non-void function (see #580)

cores/arduino/SafeRingBuffer.h

@@ -41,6 +41,12 @@ int SafeRingBufferN<N>::read_char() {
   synchronized {
     return RingBufferN<N>::read_char();
   }
+
+  // We should never reached this line because the synchronized {} block gets
+  // executed at least once. However the compiler gets confused and prints a
+  // warning about control reaching the end of a non-void function. This
+  // silences that warning.
+  return -1;
 }
 
 template <int N>
@@ -53,4 +59,4 @@ void SafeRingBufferN<N>::store_char(uint8_t c) {
 }
 
 #endif /* _SAFE_RING_BUFFER_ */
-#endif /* __cplusplus */
+#endif /* __cplusplus */