Fix wrong bracket match rectangle on auto format #9551
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes #9544
When setText is called on editorTab the rectangle that highlights
the bracket match becomes incorrect.
This is because text is inserted to the document without notifying the textarea.
Calling setLineWrap internally fires an event that recalculates the bracket
match rectangle and thus solves the problem.
A more straightforward way would have been calling the function
"doBracketMatching" on textarea but the function is protected.
Actually setLineWrap is the only public function that I am able to find
that internally (eventually) calls doBracketMatching.
I am not familiar with your testing framework and couldn't find any
information about it to run the tests so I only tested the changes manually.
All Submissions:
Changes to Core Features: