String relational operators #7194
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The String class has an incomplete set of relational operators with `const char*`. The 6 operators `==`,`!=`,`<`,`>`,`<=`,`>=` must be defined between String and String, but also between String and `const char*`. The motivation is to treat left and right operands symmetrically. str == "hello" works, but swapping arguments to "hello" == str doesn't, which is a potential user surprise. As String is implicitly convertible from `const char*`, but this incurs a "strdup". So it also makes sense to provide relational operators directly with const char* to avoid the expensive promotion of const char* to temporary String, just to do a string value comparison. Resolves: #7139
facchinm
added
the
Print and Stream class
|
|
|
signed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The String class has an incomplete set of relational operators with
const char*. The 6 operators==,!=,<,>,<=,>=must bedefined between String and String, but also between String and
const char*.The motivation is to treat left and right operands symmetrically. str
== "hello" works, but swapping arguments to "hello" == str doesn't,
which is a potential user surprise.
As String is implicitly convertible from
const char*, but this incursa "strdup". So it also makes sense to provide relational operators
directly with const char* to avoid the expensive promotion of const
char* to temporary String, just to do a string value comparison.
Resolves: #7139