Update Sketch menu in IDE GUI #2331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the useRecursion and srcFolders were filled on library creation, based on the existence of the src folder. Now, a layout variable is set, and the useRecursion() and getSrcFolder() methods change their return value based on the layout in use.
This simplifies upcoming changes.
Nobody was using it anymore, except for checking against specific extensions, which is easily done against the filename itself. This prepares for some simplification of Sketch.load next.
Removed a lot of duplicate/unused code. Preferences un-marshalling is now handled in PreferencesMap class.
Moved GUI fields into a SketchCodeDoc container class.
Create a class SketchData to store all relevant data for a sketch (trying to keep GUI stuff out of the way). Moved preprocessing code from Sketch to Compiler.
SketchCodeDoc renamed to SketchCodeDocument. Compiler is now independent from SketchCodeDocument.
Created a class PreferencesData to manage all parameters except the ones for the GUI. Removed GUI parameters management from ParametersMap. Created ParametersHelper class to help with GUI parameters management. Used ParametersHelper in Themes.
Also removed unused ColorSelector and CreateFont to reduce wrappers size to the minimum. This commit is preparatory for dropping dependency on processing-core.
Moved from Base into a specific utility class OSUtils. Removed unused platform constants.
…ods) from Base to BaseNoGui (work in progress).
…i (work in progress).
…ase to BaseNoGui (work in progress).
…rning() from BaseNoGui.
…app.linux.Platform and processing.app.windows.Platform.
Now the the GUI and the rest of the code should be completely separated.
--buildpath --nouploadport --useprogrammer
BEWARE: HIGHLY EXPERIMENTAL BRANCH
…ino-core' project.
* Have "Save Hex" option (with Ctrl + Shift + R as well) * Move Upload and Upload w/ Programmer into Sketch menu as they are functions of sketch and not file technically Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
Signed-off-by: Arnav Gupta <championswimmer@gmail.com>
cmaglie
force-pushed
the
ide-1.5.x-gui-refactor
branch
from
2339395 to
89a442b
Compare
cmaglie
force-pushed
the
ide-1.5.x-gui-refactor
branch
3 times, most recently
from
fc88ce5 to
b0b40da
Compare
cmaglie
force-pushed
the
ide-1.5.x-gui-refactor
branch
from
b0b40da to
7b2ed12
Compare
|
@championswimmer |
|
done Arnav Gupta (championswimmer) On 18 November 2014 23:39, Cristian Maglie notifications@github.com wrote:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as they are functions of sketch and not file technically
Signed-off-by: Arnav Gupta championswimmer@gmail.com