Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an example #42

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added an example #42

wants to merge 4 commits into from

Conversation

jeeva2812
Copy link

@jeeva2812 jeeva2812 commented Mar 18, 2020

Example to portray the use of read function

examples/Read/Read.ino Outdated Show resolved Hide resolved
examples/Read/Read.ino Outdated Show resolved Hide resolved
examples/Read/Read.ino Show resolved Hide resolved
@jeeva2812
Copy link
Author

Will do all the required changes

@jeeva2812 jeeva2812 requested a review from per1234 March 22, 2020 09:14
@jeeva2812
Copy link
Author

PR updated

@per1234 per1234 dismissed their stale review March 22, 2020 09:18

Requested changes have been made. Thanks!

@per1234 per1234 removed their request for review March 10, 2021 00:00
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

@jeeva2812
Copy link
Author

Can you please approve this PR @per1234

@per1234
Copy link
Contributor

per1234 commented Apr 10, 2021

Hi @jeeva2812. I commented last year that the changes I requested during my review has been resolved:
#42 (comment)

Requested changes have been made. Thanks!

It is not my role in this project to decide which examples are accepted into the library though.

@per1234 per1234 added type: enhancement Proposed improvement topic: documentation Related to documentation for the project labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants