Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create JoystickControl.ino #41

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Create JoystickControl.ino #41

wants to merge 2 commits into from

Conversation

AsherThomasBabu
Copy link

Example to allow 2 servos to be controlled via a joystick module

@AsherThomasBabu
Create JoystickControl.ino
7957d1c 
Example to allow 2 servos to be controlled via a joystick module
per1234
per1234 requested changes Mar 15, 2020
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do a Tools > Auto Format if using the Arduino IDE or Ctrl + B if using the Arduino Web Editor to make your code readable.

examples/JoystickControl/JoystickControl.ino Outdated Show resolved Hide resolved
examples/JoystickControl/JoystickControl.ino Outdated Show resolved Hide resolved
examples/JoystickControl/JoystickControl.ino Outdated Show resolved Hide resolved
examples/JoystickControl/JoystickControl.ino Outdated Show resolved Hide resolved
examples/JoystickControl/JoystickControl.ino Outdated Show resolved Hide resolved
@AsherThomasBabu
Copy link
Author

@per1234 Thank you for being so patient with me, These are my first few contributions. I changed the variable names to be in camelCase. I shall keep these in mind for my next contributions.
Also, I noticed that many examples in other libraries do not follow the convention for the variables, shall I go ahead and change them?
Thank you

@AsherThomasBabu AsherThomasBabu requested a review from per1234 March 15, 2020 04:36
@AsherThomasBabu AsherThomasBabu mentioned this pull request Mar 28, 2020
Closed
@per1234 per1234 removed their request for review March 10, 2021 00:01
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@per1234 per1234 added type: enhancement Proposed improvement topic: documentation Related to documentation for the project labels Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 requested changes

Assignees
No one assigned
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AsherThomasBabu @CLAassistant @per1234