Skip to content

Add GIGA R1 WiFi as compatible #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024

Conversation

Hannes7eicher
Copy link
Contributor

This PR adds the Arduino Giga R1 WiFi as compatible board to in the comments to the following examples:

@aliphys
Copy link
Contributor

aliphys commented Jun 12, 2024

Do the examples function as expected when running on the GIGA R1 WiFi for you?

Co-authored-by: Ali Jahangiri <75624145+aliphys@users.noreply.github.com>
@Hannes7eicher
Copy link
Contributor Author

@aliphys I can confirm I successfully tested the examples.

@Hannes7eicher Hannes7eicher changed the title Add Giga R1 WiFi as compatible Add GIGA R1 WiFi as compatible Jun 13, 2024
@alrvid alrvid self-requested a review June 13, 2024 13:34
Copy link
Contributor

@alrvid alrvid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, considering that the author also confirms he has run the examples successfully

@alrvid alrvid merged commit b18b10a into arduino-libraries:main Jun 13, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants