Skip to content
This repository has been archived by the owner on Feb 28, 2024. It is now read-only.

Dual Core Example/Functionality #85

Open
will2055 opened this issue Apr 19, 2022 · 7 comments
Open

Dual Core Example/Functionality #85

will2055 opened this issue Apr 19, 2022 · 7 comments
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement

Comments

@will2055
Copy link

There isn't an example to use the dual core feature of the H7 controller. The current library won't compile for M4 core unless #ifdef CORE_CM7 ... #endif are used to contain the RS485 and COM classes.

The Machine Control board is advertised to feature the dual core power of the Portenta H7 controller. However, the current library doesn't allow for that.

@per1234 per1234 added topic: documentation Related to documentation for the project type: enhancement Proposed improvement labels Apr 19, 2022
@elastra21
Copy link

Does anybody fixed this?, I'm facing the same issue

@elastra21
Copy link

Fixed, for those with the same issue https://github.com/elastra21/Arduino_MachineControl

@JustusRijke
Copy link

same issue here, would be great if @elastra21 fix can be merged to the library

@will2055
Copy link
Author

@elastra21 Could you provide a brief summary of what changes you made for this fix?

@elastra21
Copy link

Yeah as you commented at the start, I just change this '#ifdef CORE_CM7 in Arduino_MachineControl.h

@manchoz
Copy link
Collaborator

manchoz commented Jul 26, 2022

Hi @elastra21, would you mind creating a PR from your proposed changes? This will help discussing your proposed changes and eventually merging them.

@elastra21
Copy link

Hi @elastra21, would you mind creating a PR from your proposed changes? This will help discussing your proposed changes and eventually merging them.

PR submitted.

@per1234 per1234 linked a pull request Oct 26, 2022 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic: documentation Related to documentation for the project type: enhancement Proposed improvement
Projects
None yet
5 participants