-
Notifications
You must be signed in to change notification settings - Fork 37
Add channel mask to LoraWan constructor and expose LoraWan modem getters #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add channel mask to LoraWan constructor and expose LoraWan modem getters #68
Conversation
Memory usage change @ 45f17ab
Click for full report table
Click for full report CSV
|
@aentinger @pennam can you please review ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be better to add a specific enum for subfrequency band here https://github.com/arduino-libraries/MKRWAN/blob/5cc2f53395ffd7fdaabc213471dc08d37f2aa96c/src/MKRWAN.h#L262-L267 to be used as function argument
Memory usage change @ 832f180
Click for full report table
Click for full report CSV
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Please have a look at the comments for details.
One general question: Do we really need all those get-methods? In general I prefer to keep any API as small as possible without compromising functionality. Looks to me like all those getters mainly serve debugging purposes during development?
Enable setting sub band frequency into LoraWan Connection handler constructor.
Expose LoraWan modem getters.