chore: add unit test

Author: ardikabs

.gitignore

@@ -0,0 +1,8 @@
+.vscode/
+.idea/
+config.yaml
+.env
+.envrc
+cover.out
+vendor/**
+.DS_Store

Makefile

@@ -0,0 +1,59 @@
+GOMIGRATE_VERSION = 4.14.1
+GOLANGCI_VERSION = 1.31.0
+PLATFORM := $(shell uname | tr '[:upper:]' '[:lower:]')
+PATH := bin:$(PATH)
+SHELL := env PATH=$(PATH) /bin/bash
+
+## help: print this help message
+.PHONY: help
+help:
+	@echo 'Usage:'
+	@sed -n 's/^##//p' ${MAKEFILE_LIST} | column -t -s ':' |  sed -e 's/^/ /'
+
+.PHONY: confirm
+confirm:
+	@echo -n 'Are you sure? [y/N] ' && read ans && [ $${ans:-N} = y ]
+
+bin/golangci-lint: bin/golangci-lint-${GOLANGCI_VERSION}
+	@ln -sf golangci-lint-${GOLANGCI_VERSION} bin/golangci-lint
+
+bin/golangci-lint-${GOLANGCI_VERSION}:
+	@mkdir -p $(OUTDIR)
+	curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b ./bin/ v${GOLANGCI_VERSION}
+	@mv bin/golangci-lint "$@"
+
+## audit: tidy and vendor dependencies and format, vet, lint and test all code
+.PHONY: audit
+audit: fmt tidy lint vet test
+	@echo 'Auditing code done'
+
+## vet: vetting code
+.PHONY: vet
+vet:
+	@echo 'Vetting code...'
+	@go vet $(shell go list ./... | grep -v /vendor/|xargs echo)
+
+## test: test all code
+.PHONY: test
+test:
+	@echo 'Running tests...'
+	@CGO_ENABLED=0 go test $(shell go list ./... | grep -v /vendor/|xargs echo) -cover -coverprofile=cover.out
+	go tool cover -func=cover.out
+
+## fmt: formatting code
+fmt:
+	@echo 'Formatting code...'
+	@go fmt $(shell go list ./... | grep -v /vendor/|xargs echo)
+
+## vendor: tidy dependencies
+.PHONY: tidy
+tidy:
+	@echo 'Tidying and verifying module dependencies...'
+	@go mod tidy
+	@go mod verify
+
+## lint: linting code
+.PHONY: lint
+lint: bin/golangci-lint ## Run linter
+	@echo 'Linting code...'
+	golangci-lint run

httpc/errors.go

@@ -5,4 +5,7 @@ import "fmt"
 var (
 	// ErrRetryExceeded
 	ErrRetryExceeded = fmt.Errorf("http retry exceeded the limit")
+
+	// ErrProtocolRequired
+	ErrProtocolRequired = fmt.Errorf("invalid http host, protocol/scheme is required")
 )

httpc/options.go

@@ -77,8 +77,8 @@ func WithUnmarshaler(fn UnmarshalFunc) Option {
 	}
 }
 
-// WithStatusCodeHandler set custom handler for a given HTTP status code
-func WithStatusCodeHandler(code int, fn StatusCodeHandleFunc) Option {
+// WithCustomHandler set custom handler for a given HTTP status code
+func WithCustomHandler(code int, fn StatusCodeHandleFunc) Option {
 	return func(req *Request) error {
 		if fn == nil {
 			return fmt.Errorf("status code handle func MUST not be nil")

httpc/request.go

@@ -44,6 +44,10 @@ func NewRequest(client Doer, baseURL string, opts ...Option) (*Request, error) {
 		return nil, err
 	}
 
+	if u.Scheme == "" {
+		return nil, ErrProtocolRequired
+	}
+
 	r := &Request{
 		httpc:              client,
 		url:                u,
@@ -80,53 +84,57 @@ func (r *Request) Invoke() error {
 	}
 	req.Header = r.header
 
-	var retryCount int
+	var (
+		retryCount int
+		response   *http.Response
+	)
 
 doRequest:
-	for {
-		if retryCount > r.retryLimit {
-			return ErrRetryExceeded
+	for ; retryCount <= r.retryLimit; retryCount++ {
+		if response != nil {
+			response.Body.Close()
 		}
 
-		resp, err := r.httpc.Do(req)
+		var err error
+		response, err = r.httpc.Do(req)
 		if err != nil {
 			return err
 		}
 
 		if len(r.retryOn) > 0 {
 			for _, retryOn := range r.retryOn {
-				if valid := retryOn(resp.StatusCode); valid {
-					resp.Body.Close()
-
-					retryCount++
+				if valid := retryOn(response.StatusCode); valid {
 					continue doRequest
 				}
 			}
 		}
 
-		if handler, ok := r.statusCodeHandlers[resp.StatusCode]; ok {
-			defer resp.Body.Close()
-			if err := handler(resp); err != nil {
+		if handler, ok := r.statusCodeHandlers[response.StatusCode]; ok {
+			if err := handler(response); err != nil {
 				return err
 			}
 
 			return nil
 		}
 
-		defer resp.Body.Close()
-		data, err := ioutil.ReadAll(resp.Body)
+		defer response.Body.Close()
+		data, err := ioutil.ReadAll(response.Body)
 		if err != nil {
 			return err
 		}
 
-		contentType := resp.Header.Get(HeaderContentType)
+		contentType := response.Header.Get(HeaderContentType)
 		if err := r.unmarshal(contentType, data, r.receiver); err != nil {
 			return err
 		}
 
 		break
 	}
 
+	if retryCount > r.retryLimit {
+		return ErrRetryExceeded
+	}
+
 	return nil
 }
 
@@ -135,7 +143,7 @@ func (r *Request) unmarshal(contentType string, data []byte, out interface{}) er
 	// we assume it might be also customized how to interact
 	// with the response receiver
 	if r.unmarshalFunc != nil {
-		return r.unmarshalFunc(data, out)
+		return r.unmarshalFunc(contentType, data, out)
 	}
 
 	// if out is nil, will skip the unmarshal step