Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go model codegen produces unexpected behavior for enums #29

Open
boynton opened this issue Aug 15, 2016 · 1 comment
Open

go model codegen produces unexpected behavior for enums #29

boynton opened this issue Aug 15, 2016 · 1 comment

Comments

@boynton
Copy link
Collaborator

boynton commented Aug 15, 2016

The generated SymbolSet() method on enums returns an array of the symbol names, indexed starting at 1 (the 0'th entry is the empty string). Should just be the set, without that empty string.

This may imply that the enum values should start at 0, not 1.

This would be an incompatible change.

@boynton
Copy link
Collaborator Author

boynton commented Jul 8, 2017

This does allow the distinction of a default value vs none, however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant