-
-
Notifications
You must be signed in to change notification settings - Fork 827
Fix for code scanning alert no. 31: Prototype-polluting assignment #7026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Warning Rate limit exceeded@ardatan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 26 minutes and 11 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
🚀 Snapshot Release (
|
Package | Version | Info |
---|---|---|
@graphql-tools/executor-urql-exchange |
1.0.18-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/graphql-tag-pluck |
8.3.18-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/code-file-loader |
8.1.19-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/git-loader |
8.0.23-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/github-loader |
8.0.19-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/mock |
9.0.21-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
@graphql-tools/relay-operation-optimizer |
7.0.18-alpha-20250313124128-dc15aa57546dde831fa19501588d8388394a4813 |
npm ↗︎ unpkg ↗︎ |
🦋 Changeset detectedLatest commit: dc15aa5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
💻 Website PreviewThe latest changes are available as preview in: https://9f1352d1.graphql-tools.pages.dev |
Potential fix for https://github.com/ardatan/graphql-tools/security/code-scanning/31
To fix the problem, we need to ensure that
typeName
cannot be set to__proto__
,constructor
, orprototype
. This can be done by adding a validation step before usingtypeName
as a key inthis.store
. IftypeName
is one of these forbidden values, we should throw an error or handle it appropriately.Suggested fixes powered by Copilot Autofix. Review carefully before merging.