typescript@4.7 readiness (refine generic typings via extends)
#4382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cf00ff8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/theguild/graphql-tools/FkhYnh7xkSnFGkwXpd6db7U6FGKt [Deployment for cf00ff8 failed] |
trevor-scheer
changed the title
typescript@4.7.0-betatypescript@4.7 readiness (refine generic typings via extends)
|
Thank you @trevor-scheer! |
|
@ardatan done! Thanks 😄 |
|
Thanks @trevor-scheer 🙏 |
Closed
trevor-scheer
added a commit
to apollographql/apollo-server
that referenced
this pull request
Sep 23, 2022
…rs (#6940) Similar to ardatan/graphql-tools#4382, but these didn't turn up in the 4.7 upgrade. Likely related to microsoft/TypeScript#49489. Solution is to constrain our generics appropriately. <!-- First, 🌠 thank you 🌠 for taking the time to consider a contribution to Apollo! Here are some important details to follow: * ⏰ Your time is important To save your precious time, if the contribution you are making will take more than an hour, please make sure it has been discussed in an issue first. This is especially true for feature requests! * 💡 Features Feature requests can be created and discussed within a GitHub Issue. Be sure to search for existing feature requests (and related issues!) prior to opening a new request. If an existing issue covers the need, please upvote that issue by using the 👍 emote, rather than opening a new issue. * 🔌 Integrations Apollo Server has many web-framework integrations including Express, Koa, Hapi and more. When adding a new feature, or fixing a bug, please take a peak and see if other integrations are also affected. In most cases, the fix can be applied to the other frameworks as well. Please note that, since new web-frameworks have a high maintenance cost, pull-requests for new web-frameworks should be discussed with a project maintainer first. * 🕷 Bug fixes These can be created and discussed in this repository. When fixing a bug, please _try_ to add a test which verifies the fix. If you cannot, you should still submit the PR but we may still ask you (and help you!) to create a test. * 📖 Contribution guidelines Follow https://github.com/apollographql/apollo-server/blob/main/CONTRIBUTING.md when submitting a pull request. Make sure existing tests still pass, and add tests for all new behavior. * ✏️ Explain your pull request Describe the big picture of your changes here to communicate to what your pull request is meant to accomplish. Provide 🔗 links 🔗 to associated issues! We hope you will find this to be a positive experience! Open source contribution can be intimidating and we hope to alleviate that pain as much as possible. Without following these guidelines, you may be missing context that can help you succeed with your contribution, which is why we encourage discussion first. Ultimately, there is no guarantee that we will be able to merge your pull-request, but by following these guidelines we can try to avoid disappointment. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR was initially intended to be a reproduction of build errors caused by upgrading the TS version (to
typescript@4.7.0-beta). This is now intended to be merged as-is, having resolved the build errors caused by upgrading totypescript@4.7.0-beta(followed by reverting the upgrade with no breakage).The changes introduced in this PR bring this repo to
typescript@4.7compatible while maintaining the existing typescript version for now. In doing so, a lot of the generic typings have been refined, so this seems like a win-win.I've gone through and resolved the build errors (seemed to mostly all be of the class of error mentioned in microsoft/TypeScript#48366). This seems ready to go if the maintainers agree with these changes.
Related #4381
Type of change
Please delete options that are not relevant.
This is possibly breaking if my changes affect the public API and if users are misusing the generics. To that end I would call this a patch/bug fix, but it's worth noting. Maybe this change is deserving of a changeset?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
typescript@4.7.0-betaonmain, note build failurestypescript@4.7.0-betaon this branch, build succeedsTest Environment:
@graphql-tools/...:latestv16.5.0Checklist: