Skip to content

Rename TagWithEvaluator to QueryTagEvaluator. #512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

Rename TagWithEvaluator to QueryTagEvaluator. #512

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...meworkCore/Evaluators/TagWithEvaluator.cs → ...eworkCore/Evaluators/QueryTagEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
namespace Ardalis.Specification.EntityFrameworkCore;

public class TagWithEvaluator : IEvaluator
public class QueryTagEvaluator : IEvaluator
{
private TagWithEvaluator() { }
public static TagWithEvaluator Instance { get; } = new TagWithEvaluator();
private QueryTagEvaluator() { }
public static QueryTagEvaluator Instance { get; } = new QueryTagEvaluator();

public bool IsCriteriaEvaluator { get; } = true;

Expand All @@ -15,8 +15,7 @@ public IQueryable<T> GetQuery<T>(IQueryable<T> query, ISpecification<T> specific

if (spec.OneOrManyQueryTags.HasSingleItem)
{
query = query.TagWith(spec.OneOrManyQueryTags.Single);
return query;
return query.TagWith(spec.OneOrManyQueryTags.Single);
}
}

Expand Down
2 changes: 1 addition & 1 deletion src/Ardalis.Specification.EntityFrameworkCore/Evaluators/SpecificationEvaluator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ public SpecificationEvaluator()
IgnoreQueryFiltersEvaluator.Instance,
IgnoreAutoIncludesEvaluator.Instance,
AsSplitQueryEvaluator.Instance,
TagWithEvaluator.Instance,
QueryTagEvaluator.Instance,
];
}

Expand Down
4 changes: 2 additions & 2 deletions ...Tests/Evaluators/TagWithEvaluatorTests.cs → ...ests/Evaluators/QueryTagEvaluatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
namespace Tests.Evaluators;

[Collection("SharedCollection")]
public class TagWithEvaluatorTests(TestFactory factory) : IntegrationTest(factory)
public class QueryTagEvaluatorTests(TestFactory factory) : IntegrationTest(factory)
{
private static readonly TagWithEvaluator _evaluator = TagWithEvaluator.Instance;
private static readonly QueryTagEvaluator _evaluator = QueryTagEvaluator.Instance;

[Fact]
public void QueriesMatch_GivenTag()
Expand Down
2 changes: 1 addition & 1 deletion ...Ardalis.Specification.EntityFrameworkCore.Tests/Evaluators/SpecificationEvaluatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -359,7 +359,7 @@ public void DerivedSpecificationEvaluatorCanAlterDefaultEvaluator()
result[10].Should().BeOfType<IgnoreQueryFiltersEvaluator>();
result[11].Should().BeOfType<IgnoreAutoIncludesEvaluator>();
result[12].Should().BeOfType<AsSplitQueryEvaluator>();
result[13].Should().BeOfType<TagWithEvaluator>();
result[13].Should().BeOfType<QueryTagEvaluator>();
result[14].Should().BeOfType<WhereEvaluator>();
}

Expand Down