-
Notifications
You must be signed in to change notification settings - Fork 255
Update GitHub workflows to use Linux hosts. #440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Agreed. |
ardalis
approved these changes
Feb 24, 2025
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Jul 29, 2025
This was referenced Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been using Windows hosts and LocalDb database for the CI workflows. That's mainly because of the EF6 package and
net472
target.But it's not stable, and we have random fails. The connection to localDb fails because it's not always up and ready. We can mitigate the issue by waiting for the database to be ready before running the tests.
Anyhow instead of all that, since the EF6 package targets
net9.0
too; then let's just use ubuntu hosts and run tests using onlynet9.0
runtime. We're using TestContainers, so we won't need localDb, we'll utilize the mssql container for the tests.It's a bit of a risk not to run the tests for
net472
target, but it's a rarely changing package. And also we may always run it locally.