Skip to content

Conversation

fiseni
Copy link
Collaborator

@fiseni fiseni commented Feb 20, 2025

Fixes #438.

This is another huge and very tedious PR. But, it had to be done and I'm happy with the results.

  • Updated project TFMs. Refer to the related issue for more details.
    • Ardalis.Specification - net8.0;net9.0;netstandard2.0
    • Ardalis.Specification.EntityFrameworkCore - net8.0;net9.0
    • Ardalis.Specification.EntityFramework6 - net8.0;net9.0;net472;
  • Updated all NuGet dependencies.
  • Added CPM Directory.Packages.props
  • Added Directory.Build.props.
  • Updated and improved NuGet package generation.
    • Generate deterministic builds.
    • Generate symbol packages (*.snupkg).
    • Enable SourceLink
  • Restructured the repo and solution structure. Now we can use single build.props for all NuGet projects, and another one for all test projects. This simplifies and standardizes the configuration quite a bit.
  • Removed all docker-related files. We're using Testcontainers and no longer need them.
  • Added script for coverage generation.
  • Updated GitHub workflows.
  • Consolidated .gitignore. Added .gitattributes file.
  • Consolidated .editorconfig. Added exclusion.dic file (contains keywords to be ignored by spelling checks).
  • Consolidated global usings.
  • Run code cleanup.

@fiseni fiseni requested a review from ardalis February 20, 2025 12:08
@fiseni
Copy link
Collaborator Author

fiseni commented Feb 22, 2025

@ardalis
Before I forget, let me know if you want to change the following info. Do you want to keep Ardalis.com or modify it to NimblePros or something else.

<Company>Ardalis.com</Company>
<Copyright>Copyright © 2025 Ardalis</Copyright>

The file in the PR:
https://github.com/ardalis/Specification/blob/50dceabb41e7c7e699ed7dab9f7bbffc719977c5/src/Directory.Build.props

@ardalis
Copy link
Owner

ardalis commented Feb 24, 2025

It can stay Ardalis since it's an Ardalis.* package.

Copy link
Owner

@ardalis ardalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a lot but it looks good to me.

{5EB4ADA4-5258-4964-BD7D-11D4F926E344} = {B19F2F64-4B22-48C2-B2F8-7672F84F758D}
{5AFD1454-E625-451D-A615-CEB7BB09AA65} = {B19F2F64-4B22-48C2-B2F8-7672F84F758D}
{37EC09C7-702D-4539-B98D-F67B15E1E6CE} = {327AEBD6-C8A6-4851-BA42-632F8014CFC5}
{4BEB4DC4-DE33-4DF1-8A2F-CE76C1D72A4A} = {327AEBD6-C8A6-4851-BA42-632F8014CFC5}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thankfully we'll have slnx file support now/soon!

This was referenced Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update TFMs
2 participants