-
Notifications
You must be signed in to change notification settings - Fork 255
Create new CI and Release workflows. #350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sounds great; let's see them in action! |
Also, nice use of a solution filter; I probably would have created a separate ci.sln file to do the same thing, but your approach is cleaner I think. |
This was referenced Jul 21, 2025
This was referenced Jul 31, 2025
Closed
Closed
This was referenced Aug 26, 2025
Open
This was referenced Sep 4, 2025
Open
This was referenced Sep 15, 2025
This was referenced Sep 26, 2025
Bump Ardalis.Specification.EntityFrameworkCore from 7.0.0 to 9.3.1
SHAHZADKHAN779/ECommerceWebsite#5
Open
This was referenced Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #349. Please check the related issue for more details.
Removed the old workflows and created two new ones. I think the workflows now are stupid simple :)
ci.yml
- Build and test, triggered on pr and push on main. Triggered only if there are changes in the library projects. All other changes for docs or sample apps won't trigger anything. It's tedious if CI is triggered on each doc change.release.yml
- Triggered on release publish. We're anyway always creating releases from Github, so let's use that event. This will publish all three packages (but that's what we're always doing). If in the future we need to publish them independently, we might use different tags for each package, but for now, that seems unnecessary.The solution contains sample apps too, but I didn't want to build them as part of the workflows. So, instead of passing all the required projects as an argument to
dotnet build
, I created a solution filterci.slnf
which contains only the necessary projects. I think this was a great trick, and makes the yml files way cleaner.