Skip to content

cache and reuse scanned enum options#98

Merged
ardalis merged 2 commits into
ardalis:masterfrom
norvegec:perf/removed-excessive-assembly-scans
Apr 18, 2021
Merged

cache and reuse scanned enum options#98
ardalis merged 2 commits into
ardalis:masterfrom
norvegec:perf/removed-excessive-assembly-scans

Conversation

@norvegec
Copy link
Copy Markdown
Contributor

@norvegec norvegec commented Nov 30, 2020

Since GetAllOptions() method

  • performs assembly scan
  • is private
  • used 3 times in the class
    it makes sense to cache it's result.

@norvegec
Copy link
Copy Markdown
Contributor Author

norvegec commented Dec 1, 2020

Could be superseded with #100

@chaughawout
Copy link
Copy Markdown

#104 might benefit from some details here.

@norvegec
Copy link
Copy Markdown
Contributor Author

norvegec commented Jan 3, 2021

This PR

  • contains non-functional, performance improvements
  • doesn't contain breaking changes
  • all tests are passed
    @ardalis what else is required to move forward with it? Since you are the author and maintainer, could you give some feedback?

@ardalis
Copy link
Copy Markdown
Owner

ardalis commented Apr 18, 2021

Sorry - maintaining a bunch of projects and this one has fallen behind in my rotation of keeping things updated.

@ardalis ardalis merged commit 68b1614 into ardalis:master Apr 18, 2021
@ardalis
Copy link
Copy Markdown
Owner

ardalis commented Apr 18, 2021

Thanks! Will try to get a new release out with this fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants