Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cache and reuse scanned enum options #98

Merged
merged 2 commits into from
Apr 18, 2021
Merged

cache and reuse scanned enum options #98

merged 2 commits into from
Apr 18, 2021

Conversation

norvegec
Copy link
Contributor

@norvegec norvegec commented Nov 30, 2020 •
edited
Loading

Since GetAllOptions() method

  • performs assembly scan
  • is private
  • used 3 times in the class
    it makes sense to cache it's result.

@norvegec
Copy link
Contributor Author

norvegec commented Dec 1, 2020

Could be superseded with #100

@chaughawout
Copy link

#104 might benefit from some details here.

@norvegec
Copy link
Contributor Author

norvegec commented Jan 3, 2021

This PR

  • contains non-functional, performance improvements
  • doesn't contain breaking changes
  • all tests are passed
    @ardalis what else is required to move forward with it? Since you are the author and maintainer, could you give some feedback?

@ardalis
Copy link
Owner

ardalis commented Apr 18, 2021

Sorry - maintaining a bunch of projects and this one has fallen behind in my rotation of keeping things updated.

@ardalis ardalis merged commit 68b1614 into ardalis:master Apr 18, 2021
@ardalis
Copy link
Owner

ardalis commented Apr 18, 2021

Thanks! Will try to get a new release out with this fix soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ardalis ardalis ardalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@norvegec @chaughawout @ardalis