TEnum[] to List<TEnum> for webassembly compatibility issue in .net 9 #557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ardalis
approved these changes
Nov 18, 2024
|
This shouldn't have any public impact, right? So, I can probably just ship it with a point release. |
|
@ardalis Correct. Thank you for the quick review |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ardalis I confirmed this change fixes the issue, as suggested by @DataByte-James in #556. Seems to be a quirk with .NET 9 webassembly/mono runtime that affects arrays, and not lists. This issue is looking like it will be addressed by MS too.. (dotnet/runtime#109931) but this change should have no negative impact.
Hopefully this could get a quick review if possible.
Thank you