Upgraded to Net480 and corrected SmartEnum package reference #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
These package reference updates are in reference to issue #113 . It wasn't too difficult to see that it was referencing the old SmartEnum version in the sub-packages.
In particular, I was using Ardalis.SmartEnum.JsonNet so I started there. When the SmartEnum version is updated in Ardalis.SmartEnum.JsonNet, it gives a compatibility issue with the .NET Framework version 4.5.2, which is why it is updated to the latest .NET Framework. I went ahead and updated each project to have the same versions.
Following this, I no longer received any errors when using the latest versions of SmartEnum.
First time doing a pull request to an open source project, so let me know if I did anything incorrectly...