Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing nuget packages #40

Closed
peterbom86 opened this issue Jan 25, 2019 · 15 comments
Closed

Missing nuget packages #40

peterbom86 opened this issue Jan 25, 2019 · 15 comments
Assignees

Comments

@peterbom86
Copy link

I've tried to install Ardalis.SmartEnum.AutoFixture, but it seems to be missing?

PM> Install-Package Ardalis.SmartEnum.AutoFixture
Install-Package : Unable to find package 'Ardalis.SmartEnum.AutoFixture'
At line:1 char:1
+ Install-Package Ardalis.SmartEnum.AutoFixture
+ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ CategoryInfo          : NotSpecified: (:) [Install-Package], Exception
+ FullyQualifiedErrorId :  NuGetCmdletUnhandledException,NuGet.PackageManagement.PowerShellCmdlets.InstallPackageCommand
@ardalis
Copy link
Owner

ardalis commented Jan 25, 2019

@aalmada Do I need to publish each one of these as separate nuget package, or is there a better way to manage it?

  • AutoFixture
  • JsonNet
  • MessagePack
  • ProtoBufNet
  • Utf8Json

I guess I was hoping we could bundle them all as a meta-package or something. Thoughts? Hopefully I won't need to re-publish them with every minor update to SmartEnum. They seem not to require that.

@attiqeurrehman
Copy link

@ardalis Wouldn't be bundling one package we get more bits than we bargained for? I mean if I am not using ProtoBufNet I don't need bits with respects it?

@ardalis
Copy link
Owner

ardalis commented Mar 6, 2019

I get that. It's just more effort on my side to manage several different packages. I need to set some time aside (or have someone PR) to automate it so it's effortless.

@CumpsD
Copy link

CumpsD commented Mar 27, 2019

Just got bit by this too, after reading the README I discovered they aren't on nuget.org

@waynethompson
Copy link

Just got bit by this too, after reading the README I discovered they aren't on nuget.org
Where does it say that. I have just copied the file to my project for now.
There isn't much to them. I would include in the base nuget package.

@ardalis ardalis self-assigned this Aug 30, 2019
@DunnJM
Copy link

DunnJM commented Dec 24, 2019

What's the solution for this? I can't seem to install the serialisation package either.

@danielmeza
Copy link
Contributor

I can help with, for do that we can reorder the solution and split up in

  • src/
    For ship-able code
  • tests/
    For all the tests projects
    Also I will create a Directory.Build.props to reduce the effort
    This way we can simplify the packaging process

@ardalis
Copy link
Owner

ardalis commented Jan 15, 2020

@danielmeza sounds good, please send a PR when you have time.

@danielmeza
Copy link
Contributor

@ardalis I made the pull request.

@ankitvijay
Copy link

HI @ardalis, I see that the Pull request raised by @danielmeza for this issue has not been merged.
Here is PR: #62
Is there anything I could do to help merge this request? I'm exploring to use SmartEnum in one of our projects and these additional Nuget packages will be of great help.
Thanks!
Ankit

@danielmeza
Copy link
Contributor

@ankitvijay the pull request is done! Now we need to include documentation, you can help with that? The next step is to join to .net foundation.

@ankitvijay
Copy link

Hi, @danielmeza sure, would love to add bits to the documentation.
ReadMe.md appears to be updated already. Can you help me understand where and what else needs to be updated?

@danielmeza
Copy link
Contributor

Yes! The missing part are the recently added nugget packages to support Utf8Json, MessagePack etc.

@ankitvijay
Copy link

Great! and good to see that PR has been merged. Thanks, @danielmeza, and @ardalis :)

@ardalis
Copy link
Owner

ardalis commented Jun 19, 2020

These are published now.
https://www.nuget.org/packages?q=Ardalis.SmartEnum

@ardalis ardalis closed this as completed Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants