Add NullOrEmpty and NullOrWhiteSpace overloads for ReadOnlySpan<char>#237
Merged
Conversation
Marvin-Brouwer
suggested changes
Oct 10, 2022
Marvin-Brouwer
left a comment
Marvin-Brouwer
left a comment
Contributor
There was a problem hiding this comment.
I have some possible suggestions
Contributor
Author
|
It looks like all changes are made |
Contributor
|
The code looks great to me, I just spotted one last thing. |
Contributor
|
@ardalis I had a check on the PR, is anyone allowed to just approve it? |
Marvin-Brouwer
approved these changes
Oct 10, 2022
|
This seems like a good addition to the library. Making an attempt at resurrecting this PR. |
Reapism
approved these changes
Feb 15, 2023
Owner
|
Merged; will try to get a release out this month! |
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
This was referenced May 4, 2026
This was referenced May 15, 2026
This was referenced May 23, 2026
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #220