Remove WriteGraph; resolves #439. #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation PR: archivesunleashed/aut-docs#54 |
Codecov Report
@@ Coverage Diff @@
## master #441 +/- ##
==========================================
- Coverage 77.41% 75.55% -1.87%
==========================================
Files 41 40 -1
Lines 1519 1395 -124
Branches 278 265 -13
==========================================
- Hits 1176 1054 -122
Misses 218 218
+ Partials 125 123 -2 |
|
@ianmilligan1 @SinghGursimran If this is merged, it will make #397 unnecessary. Before we do merge, let me finish archivesunleashed/aut-docs#34. Should be straightforward now that #437 is merged. |
|
archivesunleashed/aut-docs#34 is ready to go now. |
ianmilligan1
approved these changes
Apr 14, 2020
ianmilligan1
pushed a commit
to archivesunleashed/aut-docs
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue(s): #439
What does this Pull Request do?
Removes
WriteGraphas it is redundant, and not as fully fleshed out asWriteGraphmlandWriteGEXF.How should this be tested?
Additional Notes:
Rationale is more fully fleshed out here.