Skip to content

Fix for completion error with callables #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 6, 2017

Conversation

PMoureu
Copy link
Contributor

@PMoureu PMoureu commented Mar 3, 2017

error thrown with a dot after ()

doc.GetType().

@daren-thomas
Copy link
Member

Wow! Thanks! Looks good to me. I'm going to merge this without checking it, since it is a small change that won't break existing functionality. Thank you so much for contributing :)

@daren-thomas daren-thomas merged commit b826cd1 into architecture-building-systems:master Mar 6, 2017
@PMoureu
Copy link
Contributor Author

PMoureu commented Mar 6, 2017

Thanks! I saw that the Ironlab use the same check, maybe we can provide others enhancements by merging whats mergeable in both project, i will take a look at this.

I also tested Innosetup, i managed to provide an installer for the Revit2015 fix.
I used the unicode version of Innosetup, so the output file is slightly larger, is this problematic ?

@daren-thomas
Copy link
Member

I don't think so. But I think I should probably make the installers on my machine. I'll set some time aside for that this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants