Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ResourceInstanceDataType.get_display_value() re-queries for related resources #11632

Open
jacobtylerwalls opened this issue Nov 18, 2024 · 0 comments
Open

ResourceInstanceDataType.get_display_value() re-queries for related resources #11632

jacobtylerwalls opened this issue Nov 18, 2024 · 0 comments
Labels
Subject: Performance

Comments

@jacobtylerwalls
Copy link
Member

jacobtylerwalls commented Nov 18, 2024 •
edited
Loading

If you have Resource model instances in hand for related resources, e.g. during the middle of ResourceInstanceListDataType.to_json(), you cannot provide them to ResourceInstanceDataType.get_display_value(), which will query for them again.

I added a little test for the ri-list to_json() fix. It exposed a very similar additional problem, but I don't think I'll get to it in this PR.

Originally posted by @jacobtylerwalls in #11517 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Subject: Performance
Projects
pipeline
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jacobtylerwalls