Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert_graph view unnecessarily serializes the graph #11585

Open
jacobtylerwalls opened this issue Oct 28, 2024 · 0 comments
Open

revert_graph view unnecessarily serializes the graph #11585

jacobtylerwalls opened this issue Oct 28, 2024 · 0 comments

Comments

@jacobtylerwalls
Copy link
Member

dev/8.0.x
Graph Designer:

  1. Move a node in the sidebar, this issues a POST and exposes a Revert Graph button
  2. Click Revert Graph

Result: some slowness for larger graphs


We serialize the graph here when returning a response...

return JSONResponse(
{
"graph": editable_future_graph,
"title": _("Success!"),
"message": _(
"The graph has been updated. Please click the OK button to reload the page."
),
}

...but we don't use it because we immediately reload the page:

if (status === 'success') { window.location.reload(); }

Suggest we not serialize the graph if we don't plan to use it, and also adjust the response message to not refer to clicking an OK button, as that's not the experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

No branches or pull requests

1 participant