[feat] Provides function interface for initializing memory management unit and switching to el2 privilege level for armv8 virtualization #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… unit and switching to el2 privilege level for armv8 virtualization
Azure-stars
reviewed
Jul 15, 2025
src/aarch64/init.rs
Outdated
| /// # Safety | ||
| /// | ||
| /// This function is unsafe as it changes the CPU mode. | ||
| #[cfg(not(feature = "arm_el2"))] |
Contributor
There was a problem hiding this comment.
Do we need to add condition-compile here for these functions? Maybe these functions can exist together?
Contributor
Author
There was a problem hiding this comment.
Right, the compilation of this function is not involved in the EL2 privilege level, and the conditional compilation here can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move init_mmu_el2 and switch_to_el2 from axplat_crates to the initialization section of axcpu