Skip to content
This repository has been archived by the owner on Oct 3, 2020. It is now read-only.

Regarding ARC Socket-Fetch Crash on Receiving Large File #18

Open
jarrodek opened this issue Jun 1, 2017 · 0 comments
Open

Regarding ARC Socket-Fetch Crash on Receiving Large File #18

jarrodek opened this issue Jun 1, 2017 · 0 comments

Comments

@jarrodek
Copy link
Collaborator

jarrodek commented Jun 1, 2017

Hi,

Sorry for the rude email shot. I'm Desmond, a graduate student from University of Michigan. Recently, I am learning Chrome HTTP request based on your ARC chrome app, and found an improvement which can greatly enhance the performance when your ARC app is receiving large data.

The package you used, Socket-Fetch, when downloading html data, used a variable SocketFetch._connection.body to save downloaded data. But regarding the code inside the _processBody function, when updating the downloads, the size of the SocketFetch._connection.body variable was not fixed, and its response became very slow when you received more than 10mb data.

This can be easily soved if you could fix the size of the SocketFetch._connection.body variable at the beginning to the header["content-length"], and then fill new data in to the body. Only 5 lines of code could significantly relieve the paining in waiting (or sometimes crash).

I was planning to fork your code on the GitHub, however, because it is the issue with the Socket-Fetch package and it is originally deposited on somewhere else, I think it is better to let you know.

Regards,
Desmond

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant