Issue 6 #7
Open
Issue 6 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eg. https://www.google.com, google.com, etc fix hardcoding of tokenizer path in test_tokenize_urls test refactor tokenizer fix bug when url contains directories the entire url would not be a single token refactor lib/tokenizer
# The first commit's message is: recognize a complete url as a token, this includes various url forms eg. https://www.google.com, google.com, etc # This is the 2nd commit message: fix hardcoding of tokenizer path in test_tokenize_urls test # This is the 3rd commit message: refactor tokenizer # This is the 4th commit message: fix bug when url contains directories the entire url would not be a single token
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6
Created new splittable
PRE_N_POST_ONLYwhich holds characters which can be both prefixes and suffixes but are only a splittable if at the beginning or end of a token with the exception of being prefixed/suffixed by other splittables.Taking the single quote
'as aPRE_N_POST_ONLYsplittable, the following would be valid use cases as a splittable:'test quotes''test quotes'.<- suffixed by another splittable('test quotes').<- prefixed and suffixed by another splittableThe following would not be valid uses as a splittable:
l'interrelationl'imagerie