Skip to content

Commit ea748e5

Browse files
authored
DOC-533 | Fix page titles (#196)
* Remove Markdown from page title for setting it in <title> * Change title separator from :: to | * Set document.title on soft navigation
1 parent 57a3340 commit ea748e5

File tree

3 files changed

+12
-6
lines changed

3 files changed

+12
-6
lines changed

site/config/_default/config.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ params:
7373
disableBreadcrumb: false
7474
disableNextPrev: false
7575
disableLandingPageButton: true
76-
titleSeparator: "::"
76+
titleSeparator: "|"
7777
themeVariant: [ "relearn-light", "relearn-dark", "learn", "neon", "blue", "green", "red" ]
7878
disableSeoHiddenPages: true
7979
additionalContentLanguage: [ "en" ]

site/themes/arangodb-docs-theme/layouts/partials/head.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33

44
{{- partial "meta.html" . }}
55
{{- $link := "<link href=\"%s\" rel=\"%s\" type=\"%s\" title=\"%s\">" }}
6-
<title>{{ if and .Title (not (eq .Title .Site.Title)) }}{{ .Title }} {{ default "::" .Site.Params.titleSeparator }} {{ end}}{{ .Site.Title }}</title>
6+
<title>{{ if and .Title (not (eq .Title .Site.Title)) }}{{ .Title | markdownify | plainify | safeHTML }} {{ default "::" .Site.Params.titleSeparator }} {{ end }}{{ .Site.Title }}</title>
77

88
<link href="{{ "/images/favicon.png" | relURL }}" rel="icon" type="image/png">
99
{{- partial "javascript.html" . }}

site/themes/arangodb-docs-theme/static/js/theme.js

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -86,14 +86,20 @@ function showSidebarHandler() {
8686

8787
var isMobile=false;
8888

89+
function decodeHtmlEntities(text) {
90+
var ta = document.createElement("textarea");
91+
ta.innerHTML = text;
92+
return ta.value;
93+
}
94+
8995
function replaceArticle(href, newDoc) {
90-
var re = new RegExp(/<title>(.*)<\/title>/, 'mg');
96+
var re = new RegExp(/<title>(.*?)<\/title>/, "m");
9197
var match = re.exec(newDoc);
92-
if (match) {
93-
title = match[1];
94-
}
9598

9699
$(".container-main").replaceWith($(".container-main", newDoc));
100+
if (match) {
101+
document.title = decodeHtmlEntities(match[1]);
102+
}
97103

98104
if (matches = href.match(/.*?(#.*)$/)) {
99105
location.hash = matches[1];

0 commit comments

Comments
 (0)