Skip to content

Print correct error message. #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 1, 2019
Merged

Print correct error message. #238

merged 2 commits into from
Aug 1, 2019

Conversation

maierlars
Copy link

No description provided.

@maierlars maierlars requested a review from neunhoef August 1, 2019 12:21
@maierlars maierlars self-assigned this Aug 1, 2019
matthewvon
matthewvon approved these changes Aug 1, 2019
View reviewed changes
Copy link

@matthewvon matthewvon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed as discussed. Thank you.

@kvahed kvahed self-requested a review August 1, 2019 12:28
kvahed
kvahed approved these changes Aug 1, 2019
View reviewed changes
Copy link
Collaborator

@kvahed kvahed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maierlars maierlars merged commit f3a95d2 into master Aug 1, 2019
@maierlars maierlars deleted the bug-fix/bad-error-message branch August 1, 2019 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewvon matthewvon matthewvon approved these changes

@kvahed kvahed kvahed approved these changes

@joerg84 joerg84 joerg84 approved these changes

@neunhoef neunhoef Awaiting requested review from neunhoef

Assignees

@maierlars maierlars

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@maierlars @matthewvon @kvahed @joerg84