Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contracts: Avoid multiple method definition warning #117

Closed
facuspagnuolo opened this issue Mar 28, 2020 · 4 comments
Closed

Contracts: Avoid multiple method definition warning #117

facuspagnuolo opened this issue Mar 28, 2020 · 4 comments

Comments

@facuspagnuolo
Copy link
Contributor

Currently, ethers is warning with WARNING: Multiple definitions for [method] when wrapping contracts
@facuspagnuolo
Copy link
Contributor Author

Fixed by #125

@sohkai
Copy link
Contributor

sohkai commented Apr 7, 2020

Was ethers giving that warning because we had overriden methods in the ABI?

@facuspagnuolo
Copy link
Contributor Author

Yes

@sohkai
Copy link
Contributor

sohkai commented Apr 7, 2020 •
edited
Loading

Gotcha, this seems like the relevant thread to track then: ethers-io/ethers.js#499

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sohkai @facuspagnuolo