fix(misconf): disable DS016 check for image history analyzer

[nikpivkin]

Description

Related issues

• Close bug(misconf): Apply AVD-DS-0016 only to final layer #7368

Related PRs

• feat(misconf): add ability to disable checks by ID #7536

Checklist

• I've read the guidelines for contributing to this repository.
• I've followed the conventions in the PR title.
• I've added tests that prove my fix is effective or that my feature works.
• I've updated the documentation with the relevant information (if needed).
• I've added usage information (if the PR introduces new options)
• I've included a "before" and "after" example to the description (if the PR is a user interface change).

[knqyf263]

[DmitriyLewen]

@knqyf263 @nikpivkin
maybe i am missing something, but is it correct to just skip AVD-DS-0011?

Maybe we can improve our GuessBaseImageIndex logic or at least write in the documentation that we skip this check for "--image-config-scanners misconfig"

[knqyf263]

Since the logic is based on the assumption that the CMD is set correctly and infers the base layer, it would be difficult to detect cases where the CMD is set incorrectly, as in the AVD-DS-0011 rule.

or at least write in the documentation that we skip this check for "--image-config-scanners misconfig"

Agreed, we should show a debug message about disabled check IDs. And document maybe.

[nikpivkin]

@DmitriyLewen @knqyf263 That's reasonable. I'll create a PR for that.

[DmitriyLewen]

it would be difficult to detect cases where the CMD is set incorrectly

hmm... you are right. If user has set 2 (or more) CMDs incorrectly - we can't guess the base layer correctly.
But it seems there is no way to solve such problems 😞

[knqyf263]

But it seems there is no way to solve such problems 😞

Yes, I didn't come up with a good idea, then I decided to disable it until we find a good approach.