test(kube-bench): Add integration test for kube-bench command #98
Conversation
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
==========================================
- Coverage 11.35% 11.30% -0.05%
==========================================
Files 27 27
Lines 1295 1300 +5
==========================================
Hits 147 147
- Misses 1141 1146 +5
Partials 7 7
Continue to review full report at Codecov.
|
danielpacak
force-pushed
the
itest_kube_hunter
branch
15 times, most recently
from
728e9b0 to
2934736
Compare
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak
force-pushed
the
itest_kube_hunter
branch
from
2934736 to
34ac151
Compare
danielpacak
changed the title
| Labels: labels.Set{ | ||
| "app.kubernetes.io/name": "starboard-cli", | ||
| kube.LabelResourceKind: string(kube.KindNode), | ||
| kube.LabelResourceName: node.Name, |
There was a problem hiding this comment.
I wonder if in addition we should add a label to indicate that it's a kube-bench job? something like "starboard-app": "kube-bench" maybe? (also for pod-spec and for other kinds of tool)
There was a problem hiding this comment.
Yes. That's a very good point. I'll take it as a separate issue to review the labels to identify scan job and the underlying tools.
I think it's less relevant for Starboard CLI, but the Operator has no clue which scanner we're running in the starboard namespace.
| // TODO run by the BeforeEach callback fails when it attempts to create Kubernetes objects in the | ||
| // TODO starboard namespace that is being terminated. | ||
| // | ||
| // TODO Maybe the cleanup command should block and wait unit the namespace is terminated? |
There was a problem hiding this comment.
I think this might be a good idea for users too. I ran into this recently - cleanup followed quickly by init failed. It was pretty obvious why, but waiting for the namespace to be gone would prevent it from being a problem at all.
There was a problem hiding this comment.
Created a task to follow up #99
This PR:
/cc @krol3
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com