-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Single workload scanning with polaris #118
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ning polaris to explicitly specify the audit config path
… new features, (some names changed)
…is necessary for polaris to understand the correct type of the kind
…is necessary for polaris to understand the correct type of the kind
…rboard into polaris-single-workload
…is-single-workload
danielsagi
changed the title
Feature: now scanning single workload using polaris
Feature: Single workload scanning with polaris
Aug 13, 2020
danielpacak
suggested changes
Aug 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #118 +/- ##
==========================================
- Coverage 39.86% 38.58% -1.28%
==========================================
Files 33 33
Lines 1801 1827 +26
==========================================
- Hits 718 705 -13
- Misses 1003 1034 +31
- Partials 80 88 +8
Continue to review full report at Codecov.
|
Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
danielpacak
force-pushed
the
polaris-single-workload
branch
from
September 8, 2020 14:28
441b017
to
394edff
Compare
danielpacak
approved these changes
Sep 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the new release of the single workload scanning method of polaris (in version 1.2),
This PR integrates this feature.
From now on, instead of scanning the entire cluster for config audits, you just run:
Internal change
This introduced a change in the way we map aliases of kinds to full kinds QN
Up until now we used a switch case for resolving kind names. this method is not robust enough and can fail in some situations.
The correct way to do that, (and what this PR is introducing) is to use RESTMapper
Other than the general correctness of using a Mapper instead of a switch case,
We needed a way to figure out the api version and group name for kinds/resources when we pass the resource argument to polaris.
Tests change
Because we now use a
RESTMapper
rather than a static function. the test for resolving kinds has changed to be an integration test.closes #29