fix(helm): grant permissions to get,list,watch ciskubebenchreports #1013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1013 +/- ##
==========================================
+ Coverage 57.95% 58.12% +0.17%
==========================================
Files 70 70
Lines 9097 9097
==========================================
+ Hits 5272 5288 +16
+ Misses 3297 3284 -13
+ Partials 528 525 -3
Continue to review full report at Codecov.
|
Initially, we wanted to implement the least privileged principle by creating Role or ClusterRole depending on install mode. For example, we created Role if the target namespace was the same as the operator namespace. However, this logic was too simple because we have cluster-scoped CRDs, e.g. CISKubeBenchReport, that require ClusterRole to grant RBAC permissions. Resolves: #1001 Signed-off-by: Daniel Pacak <pacak.daniel@gmail.com>
chen-keinan
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially, we wanted to implement the least privileged principle
by creating Role or ClusterRole depending on install mode.
For example, we created Role if the target namespace was the same
as the operator namespace. However, this logic was too simple
because we have cluster-scoped CRDs, e.g. CISKubeBenchReport, that
require ClusterRole to grant RBAC permissions.
Resolves: #1001
Signed-off-by: Daniel Pacak pacak.daniel@gmail.com