Skip to content

Commit 974cf90

Browse files
authored
Update to Selenium 4.25.0 (#147) +semver:feature
* Update to Selenium 4.25.0 +semver:feature * Update ChromeDownloadsForm.java * Add waiting to stabilize testHiddenElementsNotDisplayed
1 parent 0491b03 commit 974cf90

File tree

6 files changed

+10
-9
lines changed

6 files changed

+10
-9
lines changed

pom.xml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
<dependency>
8383
<groupId>com.github.aquality-automation</groupId>
8484
<artifactId>aquality-selenium-core</artifactId>
85-
<version>4.1.0</version>
85+
<version>4.2.0</version>
8686
</dependency>
8787
<dependency>
8888
<groupId>org.apache.commons</groupId>
@@ -92,12 +92,12 @@
9292
<dependency>
9393
<groupId>com.fasterxml.jackson.core</groupId>
9494
<artifactId>jackson-databind</artifactId>
95-
<version>2.17.2</version>
95+
<version>2.18.0</version>
9696
</dependency>
9797
<dependency>
9898
<groupId>org.slf4j</groupId>
9999
<artifactId>slf4j-simple</artifactId>
100-
<version>2.0.13</version>
100+
<version>2.0.16</version>
101101
<scope>test</scope>
102102
</dependency>
103103
<dependency>

src/test/java/forms/ChromeDownloadsForm.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010

1111
public class ChromeDownloadsForm extends Form {
1212
private static final String ADDRESS = "chrome://downloads/";
13-
public static final By NESTED_SHADOW_ROOT_LOCATOR = By.id("moreActionsMenu");
13+
public static final By NESTED_SHADOW_ROOT_LOCATOR = By.cssSelector("cr-toolbar");
1414
public static final By DIV_ELEMENTS_LOCATOR = By.cssSelector("div");
1515

1616
private final ILabel lblDownloadsToolbar = getFormLabel().findElementInShadowRoot(By.cssSelector("downloads-toolbar"), "Downloads toolbar", ILabel.class);

src/test/java/tests/integration/elements/HiddenElementsTests.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package tests.integration.elements;
22

3+
import aquality.selenium.browser.AqualityServices;
34
import aquality.selenium.core.elements.ElementState;
45
import aquality.selenium.core.elements.ElementsCount;
56
import aquality.selenium.elements.interfaces.ILabel;
@@ -56,7 +57,7 @@ public void testHiddenElementsExist(Function<ElementsCount, List<ILabel>> elemen
5657
public void testHiddenElementsNotDisplayed(Function<ElementsCount, List<ILabel>> elementsListProvider) {
5758
List<ILabel> listElements = elementsListProvider.apply(ElementsCount.MORE_THAN_ZERO);
5859
Assert.assertFalse(listElements.isEmpty());
59-
Assert.assertTrue(listElements.stream().noneMatch(el -> el.state().isDisplayed()));
60+
Assert.assertTrue(AqualityServices.getConditionalWait().waitFor(() -> listElements.stream().noneMatch(el -> el.state().isDisplayed())));
6061
}
6162

6263
@Test

src/test/java/tests/usecases/devtools/DeviceEmulationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
import aquality.selenium.browser.AqualityServices;
44
import aquality.selenium.browser.devtools.EmulationHandling;
55
import com.google.common.collect.ImmutableMap;
6-
import org.openqa.selenium.devtools.v128.emulation.Emulation;
7-
import org.openqa.selenium.devtools.v128.emulation.model.DisplayFeature;
6+
import org.openqa.selenium.devtools.v129.emulation.Emulation;
7+
import org.openqa.selenium.devtools.v129.emulation.model.DisplayFeature;
88
import org.testng.Assert;
99
import org.testng.annotations.BeforeMethod;
1010
import org.testng.annotations.Test;

src/test/java/tests/usecases/devtools/NetworkSpeedEmulationTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import aquality.selenium.browser.AqualityServices;
44
import org.openqa.selenium.TimeoutException;
5-
import org.openqa.selenium.devtools.v128.network.model.ConnectionType;
5+
import org.openqa.selenium.devtools.v129.network.model.ConnectionType;
66
import org.testng.Assert;
77
import org.testng.annotations.Test;
88
import tests.BaseTest;

src/test/java/tests/usecases/devtools/OverrideUserAgentTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
import manytools.BrowserLanguageForm;
99
import manytools.UserAgentForm;
1010
import org.openqa.selenium.devtools.idealized.Network;
11-
import org.openqa.selenium.devtools.v128.emulation.Emulation;
11+
import org.openqa.selenium.devtools.v129.emulation.Emulation;
1212
import org.testng.Assert;
1313
import org.testng.annotations.BeforeMethod;
1414
import org.testng.annotations.Test;

0 commit comments

Comments
 (0)