Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transaction Stream Service] Focus contract address confusingly ignores wrapped calls #339

Open
alnoki opened this issue Apr 8, 2024 · 0 comments
Labels
transaction-stream-service Issues relating to the Transaction Stream Service

Comments

@alnoki
Copy link

alnoki commented Apr 8, 2024

cc @banool @CapCap @CRBl69

Description

The focus contract address alpha feature is presumably intended to simplify client filtering behavior: only events corresponding to a particular Move package are allowed through the top-level worker process

However, the underlying implementation appears to filter based on the public entry function rather than by the event address. E.g. if a project composes on top of another and invokes the underlying package via a wrapped function call, then the wrapping package's events (which are also the wrapped package's events) get removed

Instead, it is suggested that filtration rely on the address of emitted event types, or alternatively, the focus_contract_addresses be renamed to something like entry_function_address with an additional event_type_address

Repro

server_config:
  transaction_filter:
    focus_contract_addresses:
      - $ECONIA_ADDRESS
@alnoki alnoki added the transaction-stream-service Issues relating to the Transaction Stream Service label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
transaction-stream-service Issues relating to the Transaction Stream Service
Projects
None yet
Development

No branches or pull requests

1 participant