added gcloud sdk and kubectl in the packer, uploaded the image in to … #14763

yzaccc · 2024-09-26T03:35:04Z

Install gcloud and plugins into runs-on packer image

added gcloud sdk and kubectl in the packer
uploaded the image in to ci aws account
changed the ami for workflows

Description

How Has This Been Tested?

Validated that the new image contains gcloud in ci https://github.com/aptos-labs/aptos-core/actions/runs/11061086691/job/30733047564

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

I have read and followed the CONTRIBUTING doc
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I identified and added all stakeholders and component owners affected by this change as reviewers
I tested both happy and unhappy path of the functionality
I have made corresponding changes to the documentation

trunk-io · 2024-09-26T03:35:07Z

⏱️ 8h 10m total CI duration on this PR

Slowest 15 Jobs	Cumulative Duration	Recent Runs
run-forge-haproxy / forge	1h 28m	🟩 🟥 🟥 🟩 🟩 (+3 more)
run-forge-validator-reboot-stress-test / forge	1h	🟥 🟥 🟥 🟥 🟥 (+3 more)
run-forge-twin-validator-test / forge	48m	🟥 🟥 🟥 🟥 🟥 (+3 more)
execution-performance / single-node-performance	48m	🟥 🟩
run-forge-state-sync-failures-catching-up-test / forge	29m	🟥 🟥 🟥 🟥 🟥 (+3 more)
forge-compat-test / forge	20m	🟩
forge-framework-upgrade-test / forge	16m	🟩
run-forge-state-sync-slow-processing-catching-up-test / forge	16m	🟥 🟥 🟥 🟥 🟥 (+3 more)
determine-test-metadata	15m	🟩 ⬜ 🟩 ⬜ 🟩 (+8 more)
forge-e2e-test / forge	15m	🟩
rust-cargo-deny	14m	🟩 🟩 🟩 🟩 🟩 (+4 more)
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
rust-move-tests	10m	🟩
check-dynamic-deps	10m	🟩 🟩 🟩 🟩 🟩 (+4 more)

🚨 1 job on the last run was significantly faster/slower than expected

Job	Duration	vs 7d avg	Delta
general-lints	25s	2m

_{settings ⋅ feedback ⋅ docs ⋅ learn more about trunk.io}

…ci aws account, changed the ami for workflows

github-actions · 2024-09-27T00:06:04Z

✅ Forge suite `realistic_env_max_load` success on `edbb9f98b6f05d96021e8aae314d9d655c1dfd3e`

two traffics test: inner traffic : committed: 14631.06 txn/s, latency: 2715.55 ms, (p50: 2700 ms, p70: 2700, p90: 2900 ms, p99: 3100 ms), latency samples: 5563040
two traffics test : committed: 99.96 txn/s, latency: 1979.39 ms, (p50: 1500 ms, p70: 1600, p90: 1800 ms, p99: 12200 ms), latency samples: 1700
Latency breakdown for phase 0: ["QsBatchToPos: max: 0.236, avg: 0.222", "QsPosToProposal: max: 1.092, avg: 1.033", "ConsensusProposalToOrdered: max: 0.320, avg: 0.290", "ConsensusOrderedToCommit: max: 0.407, avg: 0.394", "ConsensusProposalToCommit: max: 0.695, avg: 0.684"]
Max non-epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 1.09s no progress at version 2794089 (avg 0.20s) [limit 15].
Max epoch-change gap was: 0 rounds at version 0 (avg 0.00) [limit 4], 8.55s no progress at version 2794087 (avg 8.55s) [limit 15].
Test Ok

github-actions · 2024-09-27T00:07:37Z

✅ Forge suite `framework_upgrade` success on `b6187e1794550f4a6b25cab0e5d40188574241da` ==> `edbb9f98b6f05d96021e8aae314d9d655c1dfd3e`

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> edbb9f98b6f05d96021e8aae314d9d655c1dfd3e (PR)
Upgrade the nodes to version: edbb9f98b6f05d96021e8aae314d9d655c1dfd3e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1245.09 txn/s, submitted: 1246.22 txn/s, failed submission: 1.13 txn/s, expired: 1.13 txn/s, latency: 2542.00 ms, (p50: 2400 ms, p70: 2700, p90: 4200 ms, p99: 5500 ms), latency samples: 109740
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1086.03 txn/s, submitted: 1087.80 txn/s, failed submission: 1.76 txn/s, expired: 1.76 txn/s, latency: 2728.09 ms, (p50: 2400 ms, p70: 2700, p90: 4500 ms, p99: 6300 ms), latency samples: 98540
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> edbb9f98b6f05d96021e8aae314d9d655c1dfd3e passed
Upgrade the remaining nodes to version: edbb9f98b6f05d96021e8aae314d9d655c1dfd3e
framework_upgrade::framework-upgrade::full-framework-upgrade : committed: 1253.50 txn/s, submitted: 1256.02 txn/s, failed submission: 2.52 txn/s, expired: 2.52 txn/s, latency: 2664.45 ms, (p50: 2400 ms, p70: 2700, p90: 4800 ms, p99: 6300 ms), latency samples: 109620
Test Ok

github-actions · 2024-09-27T00:11:19Z

✅ Forge suite `compat` success on `b6187e1794550f4a6b25cab0e5d40188574241da` ==> `edbb9f98b6f05d96021e8aae314d9d655c1dfd3e`

Compatibility test results for b6187e1794550f4a6b25cab0e5d40188574241da ==> edbb9f98b6f05d96021e8aae314d9d655c1dfd3e (PR)
1. Check liveness of validators at old version: b6187e1794550f4a6b25cab0e5d40188574241da
compatibility::simple-validator-upgrade::liveness-check : committed: 14028.66 txn/s, latency: 2370.38 ms, (p50: 2000 ms, p70: 2100, p90: 2800 ms, p99: 8400 ms), latency samples: 538300
2. Upgrading first Validator to new version: edbb9f98b6f05d96021e8aae314d9d655c1dfd3e
compatibility::simple-validator-upgrade::single-validator-upgrading : committed: 7199.21 txn/s, latency: 3783.35 ms, (p50: 4100 ms, p70: 4700, p90: 5300 ms, p99: 5400 ms), latency samples: 129340
compatibility::simple-validator-upgrade::single-validator-upgrade : committed: 7663.97 txn/s, latency: 4186.57 ms, (p50: 4300 ms, p70: 4400, p90: 6200 ms, p99: 6500 ms), latency samples: 253260
3. Upgrading rest of first batch to new version: edbb9f98b6f05d96021e8aae314d9d655c1dfd3e
compatibility::simple-validator-upgrade::half-validator-upgrading : committed: 7137.82 txn/s, latency: 3980.25 ms, (p50: 4500 ms, p70: 4700, p90: 4800 ms, p99: 4900 ms), latency samples: 134760
compatibility::simple-validator-upgrade::half-validator-upgrade : committed: 7395.39 txn/s, latency: 4345.64 ms, (p50: 4700 ms, p70: 4800, p90: 4900 ms, p99: 5000 ms), latency samples: 246120
4. upgrading second batch to new version: edbb9f98b6f05d96021e8aae314d9d655c1dfd3e
compatibility::simple-validator-upgrade::rest-validator-upgrading : committed: 10601.34 txn/s, latency: 2581.39 ms, (p50: 2500 ms, p70: 2700, p90: 4000 ms, p99: 4400 ms), latency samples: 191240
compatibility::simple-validator-upgrade::rest-validator-upgrade : committed: 10967.38 txn/s, latency: 2851.49 ms, (p50: 2600 ms, p70: 2700, p90: 5500 ms, p99: 6800 ms), latency samples: 354380
5. check swarm health
Compatibility test for b6187e1794550f4a6b25cab0e5d40188574241da ==> edbb9f98b6f05d96021e8aae314d9d655c1dfd3e passed
Test Ok

perryjrandall

yzaccc requested a review from a team as a code owner September 26, 2024 03:35

yzaccc changed the title ~~added gcloud sdk and kubectl in the packer, uploaded the image in to …~~ [wip] added gcloud sdk and kubectl in the packer, uploaded the image in to … Sep 26, 2024

Zac Yang and others added 6 commits September 26, 2024 18:10

added gcloud sdk and kubectl in the packer, uploaded the image in to …

70260bf

…ci aws account, changed the ami for workflows

temp change to test

226462a

temp change to test

af9d79a

trigger ci

ba4b06e

refined

d63b1e5

refined

b252376

yzaccc force-pushed the yzaccc/install-gcloud-and-plugins-into-runs-on branch from 6075473 to b252376 Compare September 26, 2024 22:10

Zac Yang added 2 commits September 26, 2024 18:17

test if kubectl is installed

ab9ac70

changed workflows to use new image with gcloud and kubectl

bb5011d

yzaccc changed the title ~~[wip] added gcloud sdk and kubectl in the packer, uploaded the image in to …~~ added gcloud sdk and kubectl in the packer, uploaded the image in to … Sep 26, 2024

rustielin approved these changes Sep 26, 2024

View reviewed changes

aluon approved these changes Sep 26, 2024

View reviewed changes

Merge branch 'main' into yzaccc/install-gcloud-and-plugins-into-runs-on

edbb9f9

yzaccc enabled auto-merge (squash) September 26, 2024 23:38

This comment has been minimized.

Sign in to view

perryjrandall approved these changes Sep 27, 2024

View reviewed changes

yzaccc merged commit 4f413cd into main Sep 27, 2024
89 of 94 checks passed

yzaccc deleted the yzaccc/install-gcloud-and-plugins-into-runs-on branch September 27, 2024 00:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added gcloud sdk and kubectl in the packer, uploaded the image in to … #14763

added gcloud sdk and kubectl in the packer, uploaded the image in to … #14763

yzaccc commented Sep 26, 2024 •

edited

Loading

trunk-io bot commented Sep 26, 2024 •

edited

Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

github-actions bot commented Sep 27, 2024

perryjrandall left a comment

added gcloud sdk and kubectl in the packer, uploaded the image in to … #14763

added gcloud sdk and kubectl in the packer, uploaded the image in to … #14763

Conversation

yzaccc commented Sep 26, 2024 • edited Loading

Description

How Has This Been Tested?

Key Areas to Review

Type of Change

Which Components or Systems Does This Change Impact?

Checklist

trunk-io bot commented Sep 26, 2024 • edited Loading

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

github-actions bot commented Sep 27, 2024

✅ Forge suite realistic_env_max_load success on edbb9f98b6f05d96021e8aae314d9d655c1dfd3e

github-actions bot commented Sep 27, 2024

✅ Forge suite framework_upgrade success on b6187e1794550f4a6b25cab0e5d40188574241da ==> edbb9f98b6f05d96021e8aae314d9d655c1dfd3e

github-actions bot commented Sep 27, 2024

✅ Forge suite compat success on b6187e1794550f4a6b25cab0e5d40188574241da ==> edbb9f98b6f05d96021e8aae314d9d655c1dfd3e

perryjrandall left a comment

Choose a reason for hiding this comment

yzaccc commented Sep 26, 2024 •

edited

Loading

trunk-io bot commented Sep 26, 2024 •

edited

Loading

✅ Forge suite `realistic_env_max_load` success on `edbb9f98b6f05d96021e8aae314d9d655c1dfd3e`

✅ Forge suite `framework_upgrade` success on `b6187e1794550f4a6b25cab0e5d40188574241da` ==> `edbb9f98b6f05d96021e8aae314d9d655c1dfd3e`

✅ Forge suite `compat` success on `b6187e1794550f4a6b25cab0e5d40188574241da` ==> `edbb9f98b6f05d96021e8aae314d9d655c1dfd3e`