-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate out collection creator and owner permissions #14307
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14307 +/- ##
=======================================
Coverage 59.4% 59.4%
=======================================
Files 838 838
Lines 204587 204587
=======================================
Hits 121572 121572
Misses 83015 83015 ☔ View full report in Codecov by Sentry. |
JohnChangUK
force-pushed
the
collection-permission
branch
from
August 18, 2024 20:09
59d32aa
to
0dfb3a5
Compare
BriungRi
approved these changes
Aug 20, 2024
gregnazario
approved these changes
Aug 21, 2024
JohnChangUK
force-pushed
the
collection-permission
branch
from
August 21, 2024 18:35
0dfb3a5
to
48deb36
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JohnChangUK
force-pushed
the
collection-permission
branch
from
August 21, 2024 22:59
48deb36
to
f68531a
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
✅ Forge suite
|
✅ Forge suite
|
✅ Forge suite
|
github-actions bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Separate out collection creator and owner permissions * Separate out collection creator and owner permissions (cherry picked from commit 15c641a) # Conflicts: # aptos-move/aptos-release-builder/src/components/feature_flags.rs # aptos-move/framework/move-stdlib/doc/features.md # aptos-move/framework/move-stdlib/sources/configs/features.move # types/src/on_chain_config/aptos_features.rs
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
JohnChangUK
added a commit
that referenced
this pull request
Aug 22, 2024
* Separate out collection creator and owner permissions
JohnChangUK
added a commit
that referenced
this pull request
Aug 23, 2024
This was referenced Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Separate out collections permissions from creator and collection owner. 2 points:
Feature gated
Notes
New Functions